Crash at end of animation

dakikifr

Hi,

I've an animation (not looping) which have an event at the last key of the animation.

I recentely updated the runtime from
52420e8a37afabaf34e51a780bb3422288c7a6af
to
fa52abc7801f634cc0052909b3284283c5481aaa

Since that time, I've got a crash when my animation complete as seen in a screenshot here http://www.kikisoft.com/fichiers/crash_spine.png

Any idea?
Thanks!

kiki

PS: I sent a tweet a couple days ago, not sure if you've seen it:

Hi, you should add #include <algorithm> in CCSkeleton.cpp and CCSkeletonAnimation.cpp (required for std::min and std::max, it doesn't compile with VS2013)

Nate

I'm not able to reproduce a crash by adding an event to the last frame of spineboy's jump animation:

	"jump": {
		"events": [
			{ "time": 1.3666, "name": "headAttach", "string": "WWWWWWEEEEEEEEEEE" }
		],
		"bones": {

Can you modify spineboy.json to cause a crash?

You're right about including algorithm, done, thanks! 🙂

dakikifr

Hi Nate,

I couldn't produce the bug in the sample.
After many run on my game, I noticed that the crash is not 100% occuring (but 95%). It never happen'd before (in previous commitID).

1/ I'll try to narrow down the commitID that cause the crash
2/ I'm using another animation (a looping one) before the one that crashes, maybe it has something to do

I'll report my findings here.

Kiki

Nate

Ok, let me know if you find something and I'll dig into it ASAP.

dakikifr

Hi Nate,

quick update.

My crash is not related to the commit IDs I pasted, it can occur whatever version I'm using. It's a race condition and it depends on the platform (and I understand why).

Here's what I do:

Run an animation that have an event set at the last frame of the animation (but I think my crash, or another later, can occur even without that event)
Call clearTrack inside the event handler (like I said, I think a similar crash can occur if calling clearTrack during ANIMATION_COMPLETE event)

So, by the time I get out of the event handler, the track becomes invalid, thus causing a crash (sometimes, not always) in one of the next lines of code in AnimationState.c (my crash happens if the 'if' that checks if the track is ending is true, and trying to call a listener that does not exist).

Since I'm using a non-looping animation for this particular crash, I can discard my event and let the animation complete.

Anyway, thanks for your support and sorry for the trouble 😃

Kiki

Nate

Ah, makes sense. I just did a commit that should make it safe to change the AnimationState state from any listener. Except "end" listeners, those are special and shouldn't change AnimaitonState state.