can I edit native code like this?

bunnyruletheworld

my spine version is 3.8 and i have a question.
I use spine for Unity.

characters are using SpineAnimation Component for moving and change skin.
but for some complex reason, thier skins are in different SkeletonDataAsset
and i have to change it on runtime.

So I did as below.

        SkeletonDataAsset skeletonDataAsset = ResourceManager.ResourcesObjectLoad<SkeletonDataAsset>(_SkeletonDataAssetPath);
        if (skeletonDataAsset == null)
            return false;

        _Skeleton.skeletonDataAsset = skeletonDataAsset;
        _SkeletonAnimation.initialSkinName = skinName;
        _SkeletonAnimation.Initialize(true);

Despite the change of skeleton asset data, character have to maintain state. So, i copied prev
AnimationState, to assign it in initialized SkeletonAnimation.

        AnimationState state = _SkeletonAnimation.AnimationState;

        SkeletonDataAsset skeletonDataAsset = ResourceManager.ResourcesObjectLoad<SkeletonDataAsset>(_SkeletonDataAssetPath);
        if (skeletonDataAsset == null)
            return false;

        _Skeleton.skeletonDataAsset = skeletonDataAsset;
        _SkeletonAnimation.initialSkinName = skinName;
        _SkeletonAnimation.Initialize(true);

        _SkeletonAnimation.state = state;

and this error code printed.

IndexOutOfRangeException: Index was outside the bounds of the array.
Spine.RotateTimeline.Apply (Spine.Skeleton skeleton, System.Single lastTime, System.Single time, Spine.ExposedList1[T] firedEvents, System.Single alpha, Spine.MixBlend blend, Spine.MixDirection direction) 
(at Assets/Spine/Runtime/spine-csharp/Animation.cs:351)
Spine.AnimationState.ApplyRotateTimeline (Spine.RotateTimeline timeline, Spine.Skeleton skeleton, System.Single time, System.Single alpha, Spine.MixBlend blend, System.Single[] timelinesRotation, System.Int32 i, System.Boolean firstFrame) 
(at Assets/Spine/Runtime/spine-csharp/AnimationState.cs:505)
Spine.AnimationState.ApplyMixingFrom (Spine.TrackEntry to, Spine.Skeleton skeleton, Spine.MixBlend blend) 
(at Assets/Spine/Runtime/spine-csharp/AnimationState.cs:406)
Spine.AnimationState.Apply (Spine.Skeleton skeleton) 
(at Assets/Spine/Runtime/spine-csharp/AnimationState.cs:242)
Spine.Unity.SkeletonAnimation.ApplyAnimation () 
(at Assets/Spine/Runtime/spine-unity/Components/SkeletonAnimation.cs:217)
Spine.Unity.SkeletonAnimation.Update (System.Single deltaTime) 
(at Assets/Spine/Runtime/spine-unity/Components/SkeletonAnimation.cs:203)
Spine.Unity.SkeletonAnimation.Update () (at Assets/Spine/Runtime/spine-unity/Components/SkeletonAnimation.cs:188)

I thought the reason is gap between prev and curr skin bone count, so added this code.

    if (skeleton.bones.Items.Length <= boneIndex)
        boneIndex = 0;
    Bone bone = skeleton.bones.Items[boneIndex];

Could this cause problems? I'm in dire need of help. Thank you.

Harald

Despite the change of skeleton asset data, character have to maintain state. So, i copied prev
AnimationState, to assign it in initialized SkeletonAnimation.

Please note that you can't simply copy the AnimationState over when changing the SkeletonDataAsset (and load SkeletonData from it via Initialize(true)), since each TrackEntry of AnimationState contains a reference to an Animation object, which is of the previous SkeletonData. The animation holds animation data as indices to bones, slots, etc. If bones, slots, etc. are not identical in your two SkeletonDataAssets, then animations address the wrong bones and slots and so on.

I thought the reason is gap between prev and curr skin bone count, so added this code.

if (skeleton.bones.Items.Length <= boneIndex)
boneIndex = 0;
    Bone bone = skeleton.bones.Items[boneIndex];

Could this cause problems?

Yes, this will cause problems. Where did you add this code section?

Harald

characters are using SpineAnimation Component for moving and change skin.
but for some complex reason, thier skins are in different SkeletonDataAsset

If you are just separating skins across different SkeletonDataAsset assets, why do they have a different number of bones?

Why do you have to separate skins to multiple SkeletonDataAssets? Note that you could also merge skins, animations, and so on of multiple Spine projects to a single Spine project before exporting. If that's not an option, you could also consider merging multiple exported .json files to a single one and append e.g. skin entries to your main .json file (if bones, slots etc are exactly the same). You could also append skins programmatically after import in Unity. This all requires identical bones and slots to work however.

bunnyruletheworld

understand. instead of messing up native code, i tried different way. How about this one?

            if (csCommonFunction.SetSkeletonDataAsset(_SkeletonAnimation, _NewSkeletonDataAsset) == true)
            {
                an.initialSkinName = newSkinName;
                an.Initialize(true);

                for (int i = 0; i < tracks /* prev track entry */.Count; i++)
                {
                    Spine.TrackEntry track = tracks[i];
                    an.state.SetAnimation(i, track.Animation.Name, track.Loop).TrackTime = track.TrackTime;
                }
            }

To Make Character look like it's state maintained, I copied trackEntry for reference.

the precondition is skeletonDataAssets with the same animation list.

Thank you for advising me to use the spine correctly.

Harald

Glad it helped! The above code looks good.

If you also want to cover a more complicated setup, you might also want to call AddAnimation() after SetAnimation() for each queued animation on the same track (unless you only ever play a single animation when switching skeletons). You can query the enqueued animation TrackEntry objects like a linked list via trackEntry.Next, until at the end of the list. The easiest way however may be to ignore any queued animations and transitions, otherwise it will get complicated.

Depending on your setup you might also want to copy TrackEntry properties like trackEntry.Delay or similar properties, if you needed to set them on the initial skeleton. Nevertheless, we would recommend to keep the copy-setup simple here, to save you unnecessary problems.