Found another unity spine-2dtk runtime BUG

ryf9059

I found a easily dulicatable spine-2dtk runtime BUG: open the spineboy example, duplicate the exsiting spineboy, and run, then you will have a runtime exception:

NullReferenceException: Object reference not set to an instance of an object
tk2dSpineboy.Update () (at Assets/spine-tk2d/Example/Scripts/tk2dSpineboy.cs:23)

So basically I can only have one 2dtk-spine skeleton at a time of any kind, more than one will throw the above exception

I did some debugging and it turns out the skeleton.state is null during the update, in fact lots of variables are null during the update. But if you only have one spineboy this problem won't happen. This does not limit to spineboy, any skeleton with more than one number will have this problem.

For a single spineboy (default case), the skeleton has lots of null variable upon start by

calling skeleton = GetComponent<tk2dSpineSkeleton>();

but during the update() those variables have been magically assigned somehow. I'm not super familiar with monodevelop debugger so after start() I can on longer step into anything, the debugger literally halts, and it resumes only after I set another break point at the beginning of the update() function call, by then the skeleton will already have those value magically assigned, or not, in which case throws the exception.

Did anyone else having the same problem? I have tested it several times on different new projects and they all have the same error upon duplication.

Nate

I changed the skeleton component so it initializes in Start(). I also changed the spineboy script's Update() so it checks if there is an animation before checking the duration. You can't control what order Update() is called, and the animation is set in the skeleton component Update().

ryf9059

Nate wrote
I changed the skeleton component so it initializes in Start(). I also changed the spineboy script's Update() so it checks if there is an animation before checking the duration. You can't control what order Update() is called, and the animation is set in the skeleton component Update().

Created new project, imported new file, get this error when running

UnassignedReferenceException: The variable listItems of 'tk2dDemoCameraController' has not been assigned.
You probably need to assign the listItems variable of the tk2dDemoCameraController script in the inspector.
UnityEngine.Transform.get_localPosition () (at C:/BuildAgent/work/7535de4ca26c26ac/Runtime/ExportGenerated/Editor/UnityEngineTransform.cs:40)
tk2dDemoCameraController.Start () (at Assets/TK2DROOT/tk2d_demo/tk2dDemoCameraController.cs:17)

I didn't find anywhere to assign the script

Also mouse click will not work on spineboy anymore, if I make multiple copies the mouse click works on some of them, for some time, seemed totally random. Not sure what' causing this since no error message is produced regarding the mouse click

Nate

That error is about tk2dDemoCameraController, not sure why it happens. Maybe something is not set up right in the example project?

I also noticed the mouse click only worked intermittently. I can't imagine why, I thought maybe Unity is just being flaky. spineboy has a collider and the spineboy script has OnMouseDown. I don't see a lot of room for error with that.

I reverted my last change to the Example project and it seems to have fixed both issues. This is the kind of thing that makes me dislike Unity. It isn't clear (to me, at least) why things are happening, how to fix errors (eg if a script is missing Unity doesn't tell you what script it is looking for), etc. Give me some code any day, then I can see how it works and I can be productive. With Unity I have to understand how the black box tool works, a whole slew of conventions, etc. It is all supposed to make building games easier, but I'm not convinced.

ryf9059

Nate wrote
That error is about tk2dDemoCameraController, not sure why it happens. Maybe something is not set up right in the example project?

I also noticed the mouse click only worked intermittently. I can't imagine why, I thought maybe Unity is just being flaky. spineboy has a collider and the spineboy script has OnMouseDown. I don't see a lot of room for error with that.

I reverted my last change to the Example project and it seems to have fixed both issues. This is the kind of thing that makes me dislike Unity. It isn't clear (to me, at least) why things are happening, how to fix errors (eg if a script is missing Unity doesn't tell you what script it is looking for), etc. Give me some code any day, then I can see how it works and I can be productive. With Unity I have to understand how the black box tool works, a whole slew of conventions, etc. It is all supposed to make building games easier, but I'm not convinced.

Yeah I understand that, I'm not a big fan of unity in this aspect either, but it's the most accessible engine for indie develepers till now, just hope it can get better.

Created new project, camera problem solved. Mouse click still suffers the problem of not working intermitently if having multiple copies of spine boy (But you said it fixed both issues including the mouse problem? This is disturbing). I did some debugging by printing out animation state name on click, it turns out that OnMouseClick actually is fired everytime the mouse clicked and the animation state name is changed, but not all skeletons reflected the changes of the animation, so possibly a bug with the 2dtkskeleton script

evs

Hello,

I had the erratic jump thing with the previous version too!

But It works perfectly for me with all the latest github stuff (spine-csharp and spine-tk2d folders)

2D Toolkit 1.92 + Patch 1 (also works with 2D Toolkit 2 beta 1)

Unity 4.1.3f3 (had it working on 3.5.7, but upgraded when they made iOS and Android basic free!)
:yes:

Mac OSX 10.7.5

Cheers

evs

Nate

Thanks evs for sharing a little bit of good news. 😃

ryf9059, sorry, I meant I was seeing the intermittent clicking with just one spineboy. I finally figured out that the spineboy script Update() was being called before the tk2d skeleton Update(), which caused the animation name to get reverted before the tk2d skeleton could change the animation. Changing the script to LateUpdate() fixes it. :party:

ryf9059

Nate wrote
Thanks evs for sharing a little bit of good news. 😃

ryf9059, sorry, I meant I was seeing the intermittent clicking with just one spineboy. I finally figured out that the spineboy script Update() was being called before the tk2d skeleton Update(), which caused the animation name to get reverted before the tk2d skeleton could change the animation. Changing the script to LateUpdate() fixes it. :party:

The problem is fixed, thanks! :party:

Now the only problem left with this 2dtk integration is being unable to change the skeleton mesh size by adjusting the target height and target orthosize from the sprite collection (see screenshot). I have mentioned this problem before and I also consulted with unikron software, now I'm sure this is something to do with the integration on spine's side.
http://unikronsoftware.com/2dtoolkit/fo ... 757.0.html (start from #8)

I know you are busy with all the schedules but can you look into it when you get some time to fix the last problem? Thanks again! 🙂